Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Unable to compose schema with references #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Unable to compose schema with references #18

wants to merge 2 commits into from

Conversation

timstott
Copy link
Contributor

@timstott timstott commented Sep 21, 2018 •
edited
Loading

Description

Composing schemas with references blows up 💥 .

RangeError: Maximum call stack size exceeded
      at Object.stringify (native)
      at Object.generate_gen_validate [as gen_validate] (lib/dotjs/gen_validate.js:9:3432)
      at Object.generate_gen_validate [as gen_validate] (lib/dotjs/gen_validate.js:9:2490)
      at Object.generate_gen_validate [as gen_validate] (lib/dotjs/gen_validate.js:9:2490)

Notes

  • Only occurs when composing schemas with references
  • The issue is specific to the order in which schemas are included

@coveralls
Copy link

coveralls commented Sep 21, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 98.23% when pulling 0500437 on redbadger:composition-bug into 5d5a792 on epoberezkin:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timstott @coveralls @haines