Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wavelengths #336

Merged
merged 60 commits into from
Oct 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
50d4d62
first scaffolding of idea
ajwheeler Oct 2, 2024
d27b544
make it precompile
ajwheeler Oct 2, 2024
0896e8d
three broken tests
ajwheeler Oct 2, 2024
35688d7
make tests pass
ajwheeler Oct 4, 2024
c9071a2
another test
ajwheeler Oct 4, 2024
80ffd04
Merge branch 'main' into wavelengths
ajwheeler Oct 4, 2024
d861ee4
air to vac tests
ajwheeler Oct 4, 2024
ac70809
docstring stuff
ajwheeler Oct 4, 2024
c726b2e
some bugs
ajwheeler Oct 4, 2024
3801e60
air->vac bug
ajwheeler Oct 4, 2024
0c9171f
don't attempt to rachet
ajwheeler Oct 4, 2024
c72268f
Merge branch 'main' into wavelengths. (I want the new TODO action)
ajwheeler Oct 5, 2024
d488a92
make things work
ajwheeler Oct 5, 2024
06d1230
make more tests pass
ajwheeler Oct 5, 2024
8e38518
more
ajwheeler Oct 5, 2024
d8f6ea6
make things pass
ajwheeler Oct 5, 2024
f3fa9a1
simplyfy api
ajwheeler Oct 5, 2024
40e9506
use already-written merge_bounds function instead of duplicating it's…
ajwheeler Oct 5, 2024
c72cb8d
searchsortedfirst/last is faster than my nonsense
ajwheeler Oct 5, 2024
31e151e
make more things work
ajwheeler Oct 5, 2024
b9e789b
implement searchsortedfirst/last for Wavelengths and test it very car…
ajwheeler Oct 5, 2024
4f94098
no more move_bounds on ranges or vectors of ranges
ajwheeler Oct 5, 2024
b24469c
remove broken test, comment out ones to fix later
ajwheeler Oct 5, 2024
95f4bcd
use direct indexing
ajwheeler Oct 5, 2024
19d9ed7
eachwl is not needed
ajwheeler Oct 5, 2024
ce5642d
add TODO
ajwheeler Oct 5, 2024
3834836
most tests pass, some still don't
ajwheeler Oct 5, 2024
80abc62
add TODO
ajwheeler Oct 7, 2024
9b33878
fix test
ajwheeler Oct 7, 2024
e578c5d
work on cross sections
ajwheeler Oct 7, 2024
929cc6d
fix test
ajwheeler Oct 7, 2024
d07bed1
move merge_bounds
ajwheeler Oct 7, 2024
7f00ca7
LSFs working
ajwheeler Oct 8, 2024
4e9e2a7
write to LSF matrix along fast axis
ajwheeler Oct 8, 2024
21fd250
remove move_bounds and rectify!; make utils tests pass
ajwheeler Oct 8, 2024
2086531
slightly update fit tests
ajwheeler Oct 8, 2024
659836b
fit tests pass
ajwheeler Oct 8, 2024
46a8833
all tests pass
ajwheeler Oct 8, 2024
8f979cc
put sizes in LSF / wavelengths mismatch errors
ajwheeler Oct 10, 2024
9f562fd
it's faster
ajwheeler Oct 11, 2024
f34c27e
dep warning
ajwheeler Oct 11, 2024
322fbc6
Merge branch 'main' into wavelengths. (I want the 1.11 Project.tomls)
ajwheeler Oct 11, 2024
8b4acab
dep warning for air_wavelengths
ajwheeler Oct 11, 2024
a99dd1d
subspectra tests
ajwheeler Oct 11, 2024
8ea0a13
easy mode constructor for multiple ranges
ajwheeler Oct 11, 2024
ca7a4e2
another constructor
ajwheeler Oct 11, 2024
46c9f8e
docstrings
ajwheeler Oct 11, 2024
4926f67
clarify fit docstring
ajwheeler Oct 11, 2024
65abfa7
loosen fit precision for test
ajwheeler Oct 13, 2024
1c7e548
eliminate warnings from tests
ajwheeler Oct 15, 2024
db04c85
Merge branch 'main' into wavelengths. Resolve runtests, and get Aqua …
ajwheeler Oct 15, 2024
4581768
even more explicit error message
ajwheeler Oct 15, 2024
36476c2
time limit kwarg in fit_spectrum
ajwheeler Oct 15, 2024
1cb7cbe
appease the formatter
ajwheeler Oct 15, 2024
086d471
tweak when warning is thrown
ajwheeler Oct 16, 2024
239cfb8
update fitting tutorial to remove user-generated LSF matrix
ajwheeler Oct 16, 2024
2ea1ac5
update python fitting notebook
ajwheeler Oct 16, 2024
f7de60c
don't upgrade formatter (yet)
ajwheeler Oct 16, 2024
f484cf3
oops
ajwheeler Oct 16, 2024
0efe734
fixed now?
ajwheeler Oct 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/Format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
with:
version: 1
- run: |
julia -e 'using Pkg; Pkg.add("JuliaFormatter")'
julia -e 'using Pkg; Pkg.add(name="JuliaFormatter", version="1")'
julia -e 'using JuliaFormatter; format("."; verbose=true)'
- uses: reviewdog/action-suggester@v1
with:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ using Base
using Statistics: mean
using Interpolations: linear_interpolation, deduplicate_knots!
using Korg
using Korg: Species, ismolecule, get_atoms, _data_dir, move_bounds, @species_str
using Korg: Species, ismolecule, get_atoms, _data_dir, @species_str
using Korg: hplanck_eV, c_cgs, RydbergH_eV, kboltz_eV # constants
using CSV, DataFrames #for NIST energy level parsing

Expand Down
310 changes: 136 additions & 174 deletions misc/Tutorial notebooks/fitting/Fit spectrum in python.ipynb

Large diffs are not rendered by default.

192 changes: 109 additions & 83 deletions misc/Tutorial notebooks/fitting/Fit spectrum.ipynb

Large diffs are not rendered by default.

Loading
Loading