Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/envp #103

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Fix/envp #103

merged 2 commits into from
Mar 9, 2024

Conversation

ak0327
Copy link
Owner

@ak0327 ak0327 commented Mar 9, 2024

Summary by CodeRabbit

  • リファクタ
    • ビルドプロセスからデバッグフラグを削除しました。
  • 新機能
    • CGIハンドラに環境変数PATHを設定する機能を追加しました。

Copy link
Contributor

coderabbitai bot commented Mar 9, 2024

ウォークスルー

この変更では、Makefileからデバッグフラグを削除し、fcleanターゲットの挙動を調整しています。また、CgiHandler.cppにおいては、<cstring>ヘッダーの追加とPATH環境変数を取得・設定するロジックが導入されています。

変更

ファイル 変更の概要
Makefile -D DEBUGフラグをCXXFLAGSから削除し、fcleanターゲットで$(NAME)実行ファイルのみを削除するように変更
srcs/.../CgiHandler.cpp <cstring>ヘッダーの追加とcreate_envp関数でのPATH環境変数の取得・設定ロジックの導入

🐰✨
変更の風が吹き、コードは軽やかに、
デバッグの旗を降ろし、新たな道を歩む。
環境への扉を開き、PATHを照らす光、
未来への一歩、コードラビットの歌声。
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@ak0327 ak0327 marked this pull request as ready for review March 9, 2024 08:05
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 825d35e and 4335132.
Files selected for processing (2)
  • Makefile (2 hunks)
  • srcs/HttpResponse/CgiHandler/CgiHandler.cpp (2 hunks)
Files skipped from review due to trivial changes (1)
  • Makefile

srcs/HttpResponse/CgiHandler/CgiHandler.cpp Show resolved Hide resolved
@ak0327 ak0327 merged commit f4ce7c4 into main Mar 9, 2024
5 checks passed
@ak0327 ak0327 deleted the fix/envp branch March 9, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant