SECKSD-14473 fixed validation: did not work for PenaltyBoxProtection:…

… false
akamai · Jun 27, 2022 · 257c59e · 257c59e
1 parent 7f9286c
commit 257c59e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/pkg/appsec/eval_penalty_box_test.go b/pkg/appsec/eval_penalty_box_test.go
@@ -110,7 +110,7 @@ func TestAppSec_UpdateEvalPenaltyBox(t *testing.T) {
 				ConfigID:             43253,
 				Version:              15,
 				PolicyID:             "AAAA_81230",
-				PenaltyBoxProtection: true,
+				PenaltyBoxProtection: false,
 				Action:               string(ActionTypeDeny),
 			},
 			headers: http.Header{

diff --git a/pkg/appsec/penalty_box.go b/pkg/appsec/penalty_box.go
@@ -96,10 +96,9 @@ func (v GetPenaltyBoxesRequest) Validate() error {
 // Validate validates an UpdatePenaltyBoxRequest.
 func (v UpdatePenaltyBoxRequest) Validate() error {
 	return validation.Errors{
-		"ConfigID":             validation.Validate(v.ConfigID, validation.Required),
-		"Version":              validation.Validate(v.Version, validation.Required),
-		"PolicyID":             validation.Validate(v.PolicyID, validation.Required),
-		"PenaltyBoxProtection": validation.Validate(v.PenaltyBoxProtection, validation.Required),
+		"ConfigID": validation.Validate(v.ConfigID, validation.Required),
+		"Version":  validation.Validate(v.Version, validation.Required),
+		"PolicyID": validation.Validate(v.PolicyID, validation.Required),
 		"Action": validation.Validate(v.Action, validation.Required, validation.In(string(ActionTypeAlert), string(ActionTypeDeny), string(ActionTypeNone)).Error(
 			fmt.Sprintf("value '%s' is invalid. Must be one of: 'alert', 'deny' or 'none'", v.Action))),
 	}.Filter()