Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41 refactor major components #42

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Conversation

akefirad
Copy link
Owner

Fixes #41

@akefirad akefirad changed the title FGH-41 refactor major components GH-41 refactor major components Jan 19, 2025
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 95.74468% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.92%. Comparing base (edbd2e1) to head (914a3f8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...in/com/akefirad/groom/spock/SpockFoldingBuilder.kt 92.98% 0 Missing and 4 partials ⚠️
...m/akefirad/groom/spock/AssertInlayHintsProvider.kt 93.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   92.18%   93.92%   +1.73%     
==========================================
  Files           7        8       +1     
  Lines         128      181      +53     
  Branches       40       58      +18     
==========================================
+ Hits          118      170      +52     
+ Misses          4        3       -1     
- Partials        6        8       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akefirad akefirad force-pushed the GH-41-refactor-folding-builder branch from d7d403f to 6d91a2a Compare January 19, 2025 16:30
Copy link

github-actions bot commented Jan 19, 2025

Qodana Community for JVM

4 new problems were found

Inspection name Severity Problems
Constant conditions ◽️ Notice 2
Boolean expression can be simplified ◽️ Notice 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@akefirad akefirad force-pushed the GH-41-refactor-folding-builder branch 2 times, most recently from 8f77480 to db29ead Compare January 19, 2025 18:47
@akefirad akefirad force-pushed the GH-41-refactor-folding-builder branch from db29ead to 914a3f8 Compare January 19, 2025 19:18
@akefirad akefirad merged commit 0a826de into main Jan 19, 2025
8 checks passed
@akefirad akefirad deleted the GH-41-refactor-folding-builder branch January 19, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Major refactoring
1 participant