Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code set some expectations on the highlight command output which not
always are true. It exptected
ctermbg
to be exactly 3 chars long andguibg
to be exactly 7 chars long. This is not true for many cases. Here's for example
my
SingColumn
:New code sets a different sets of expectations that might be a bit better. New
code relies on the normalized output of
highlight
command. It parses outputand takes the part from "=" to the first space. This should cover the case of
varying length of numeric colours as well as named colours.