Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix JSON and JSONB payload DbType (failed) #173

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Attempt to fix JSON and JSONB payload DbType (failed) #173

wants to merge 3 commits into from

Conversation

Arkatufus
Copy link
Contributor

Does not Fix #171

The different payload column DbType was never tested. This PR includes serialization tests for JSON and JSONB DbTypes and, as we can see, they failed horrendously.

Problems:

  • JSONB rearranges the JSON fields, this can cause polymorphic serializer that depends on a very specific field ordering to fail (ie. Newtonsoft.Json)
  • Setting the payload column to JSON/JSONB would mean that we have to ignore the explicit Akka.NET Type to Serializer mapping settings, which is bad. This is the main cause why the TCK is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
NO-MERGE wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jsonb serialization snapshot manifest instead of qualified name uses manifest of SerializerWithStringManifest
1 participant
@Arkatufus