Add batched migration script #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to11mtm
reviewed
Feb 5, 2023
There was a problem hiding this comment.
@Arkatufus I'm looking at these with the mindset that they are expected to be modified for a specific use case.
That aside,
- We should give our function names unique names if we are using
CREATE OR ALTER, especially in the case of functions named things likeSplitwhich may have an existing declaration in a Prod DB. - We should have documentation that makes it abundantly clear to users that these scripts must be modified for their specific table configuration(s).
| BEGIN | ||
| BEGIN TRAN; | ||
| INSERT INTO [dbo].[tags]([ordering_id], [tag]) | ||
| SELECT * FROM (SELECT records.[Ordering], cross_product.[items] FROM ( |
There was a problem hiding this comment.
Would prefer specific columns over select * here
There was a problem hiding this comment.
The SELECT * is actually nescessary here, the specific columns are defined inside the inner SELECT
| WHERE ej.[Ordering] >= @from_id AND ej.[Ordering] <= @from_id + 1000 | ||
| ) AS records CROSS APPLY [dbo].[Split](records.Tags, ';') cross_product) AS s([ordering_id], [tag]) | ||
| WHERE NOT EXISTS ( | ||
| SELECT * FROM [dbo].[tags] t WITH (updlock) |
There was a problem hiding this comment.
You can probably SELECT 1 instead of SELECT * here.
|
@to11mtm makes sense, I'll try to incorporate those changes |
…n_script # Conflicts: # Akka.Persistence.Linq2Db.sln
|
@Arkatufus needs a rebase |
|
Rebased to recent dev branch in #168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add batched migration script