Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network macvlan and ipam support #16

Merged
merged 4 commits into from
Mar 31, 2024
Merged

Network macvlan and ipam support #16

merged 4 commits into from
Mar 31, 2024

Conversation

aksiksi
Copy link
Owner

@aksiksi aksiksi commented Mar 30, 2024

Closes #15.

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 78.68852% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 71.80%. Comparing base (7fdd01c) to head (9c549ef).

Files Patch % Lines
compose.go 78.20% 13 Missing and 4 partials ⚠️
nix.go 79.54% 6 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   72.08%   71.80%   -0.28%     
==========================================
  Files           6        6              
  Lines         745      830      +85     
==========================================
+ Hits          537      596      +59     
- Misses        178      197      +19     
- Partials       30       37       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aksiksi aksiksi marked this pull request as ready for review March 31, 2024 03:12
@aksiksi aksiksi changed the title macvlan and ipam support Network macvlan and ipam support Mar 31, 2024
@aksiksi aksiksi merged commit 61410e6 into main Mar 31, 2024
3 checks passed
@aksiksi aksiksi deleted the macvlan-and-ipam-support branch March 31, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macvlan Network Support in Compose File
2 participants