fix: do not wrap --health-cmd in quotes #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot wrap the health command with single quotes because Nix calls
escapeShellArg
under the hood on each entry in theExtraOptions
array.This results in us passing in the single-quote wrapped command as-is - i.e., including single quotes - to the runtime, which causes the entire quote-enclosed string to be interpreted as an executable rather than a shell command.
I have also added a simple health check to the integration test.
Fixes #22.