Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly escape Nix strings everywhere #35

Merged
merged 1 commit into from
Sep 28, 2024
Merged

fix: properly escape Nix strings everywhere #35

merged 1 commit into from
Sep 28, 2024

Conversation

aksiksi
Copy link
Owner

@aksiksi aksiksi commented Aug 23, 2024

Fix an issue where special characters were not properly escaped in template, leading to Nix parsing errors.

@aksiksi aksiksi force-pushed the escape-chars branch 3 times, most recently from 12e3f65 to da395f8 Compare August 23, 2024 14:49
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.96%. Comparing base (7c53c2f) to head (bb3292d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   71.70%   71.96%   +0.26%     
==========================================
  Files           6        6              
  Lines         735      742       +7     
==========================================
+ Hits          527      534       +7     
  Misses        166      166              
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aksiksi aksiksi changed the title Enable escaping special Nix chars in template fix: properly escape Nix strings everywhere Sep 28, 2024
@aksiksi aksiksi marked this pull request as ready for review September 28, 2024 01:16
@aksiksi aksiksi merged commit 75eac4e into main Sep 28, 2024
6 checks passed
@aksiksi aksiksi deleted the escape-chars branch September 28, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant