Skip to content

Commit

Permalink
fix broken schema and tests
Browse files Browse the repository at this point in the history
Signed-off-by: Kent Rancourt <[email protected]>
  • Loading branch information
krancour committed Sep 30, 2024
1 parent bc4c654 commit c47e21a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions internal/directives/git_pr_waiter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,17 @@ func Test_gitPRWaiter_validate(t *testing.T) {
},
},
{
name: "neither prNumber nor PRNumberFromStep specified",
name: "neither prNumber nor prNumberFromStep specified",
config: Config{},
expectedProblems: []string{
"(root): Must validate one and only one schema",
},
},
{
name: "both prNumber and PRNumberFromStep specified",
name: "both prNumber and prNumberFromStep specified",
config: Config{
"prNumber": 42,
"PRNumberFromStep": "fake-step",
"prNumberFromStep": "fake-step",
},
expectedProblems: []string{
"(root): Must validate one and only one schema",
Expand Down
4 changes: 2 additions & 2 deletions internal/directives/schemas/git-wait-for-pr-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@
{
"required": ["prNumber"],
"properties": {
"prNumberFromOpen": { "enum": ["", null] }
"prNumberFromStep": { "enum": ["", null] }
}
},
{
"required": ["prNumberFromOpen"],
"required": ["prNumberFromStep"],
"properties": {
"prNumber": { "enum": [0, null] }
}
Expand Down

0 comments on commit c47e21a

Please sign in to comment.