fix(promotion): wait for open pull request #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the immediate issue, by ensuring the Phase of the Promotion is set to Running for as long as a pull request is open. However, I do feel this is the result of us not taking a defensive approach when composing the Phase the Promotion is in, by assuming a Promotion to be Successful (in multiple places) until we are told it isn't. The less error prone approach would be to assume the opposite, but this is arguably much more difficult to achieve. Signed-off-by: Hidde Beydals <[email protected]>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2451 +/- ##
==========================================
- Coverage 48.44% 48.44% -0.01%
==========================================
Files 246 246
Lines 17724 17726 +2
==========================================
Hits 8587 8587
- Misses 8711 8713 +2
Partials 426 426 ☔ View full report in Codecov by Sentry. |
krancour
approved these changes
Aug 21, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
Signed-off-by: Hidde Beydals <[email protected]> (cherry picked from commit bab3322)
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the immediate issue (fixes #2450), by ensuring the Phase of the Promotion is set to Running for as long as a pull request is open.
However, I do feel this is the result of us not taking a defensive approach when composing the Phase the Promotion is in, by assuming a Promotion to be Successful (in multiple places) until we are told it isn't.
The less error prone approach would be to assume the opposite, but this is arguably much more difficult to achieve.