Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kubeclient): retry patch on conflict #2499

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Sep 6, 2024

Fix: #2473 #2489

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for docs-kargo-akuity-io canceled.

Name Link
🔨 Latest commit 5a7cfba
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66db74c45cc9ab000857697d

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 48.75%. Comparing base (5560a1f) to head (5a7cfba).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/kubeclient/patch.go 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2499      +/-   ##
==========================================
- Coverage   48.76%   48.75%   -0.02%     
==========================================
  Files         250      250              
  Lines       17969    17973       +4     
==========================================
  Hits         8762     8762              
- Misses       8725     8729       +4     
  Partials      482      482              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this to the v0.8.8 milestone Sep 9, 2024
@hiddeco hiddeco added this pull request to the merge queue Sep 9, 2024
Merged via the queue into akuity:main with commit 0e35be5 Sep 9, 2024
23 of 25 checks passed
@hiddeco hiddeco deleted the retry-patch-on-conflict branch September 9, 2024 16:22
github-actions bot pushed a commit that referenced this pull request Sep 9, 2024
Signed-off-by: Hidde Beydals <[email protected]>
(cherry picked from commit 0e35be5)
@akuitybot
Copy link

Successfully created backport PR for release-0.8:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto promoted Freight Error Patching ArgoCD Application
3 participants