Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug in git overwrite promotion step #2588

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

krancour
Copy link
Member

It was incorrect to ignore .git in the source dir only if it was itself a directory.

Worktrees have a .git file.

This can create problems when copying from a working tree, as .git will be copied, which was not the intention.

Signed-off-by: Kent Rancourt <[email protected]>
@krancour krancour added this to the v0.9.0 milestone Sep 27, 2024
@krancour krancour self-assigned this Sep 27, 2024
@krancour krancour requested a review from a team as a code owner September 27, 2024 23:14
Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit cb8e740
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66f73c4a37f5b600088562d6
😎 Deploy Preview https://deploy-preview-2588.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.10%. Comparing base (0e173e3) to head (cb8e740).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2588   +/-   ##
=======================================
  Coverage   51.10%   51.10%           
=======================================
  Files         282      282           
  Lines       20945    20945           
=======================================
  Hits        10703    10703           
  Misses       9578     9578           
  Partials      664      664           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this pull request to the merge queue Sep 27, 2024
Merged via the queue into akuity:main with commit 666660a Sep 27, 2024
24 checks passed
@krancour krancour deleted the krancour/git-overwrite-bug-fix branch September 27, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants