Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make git-commit promotion step check for diffs before committing #2590

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

krancour
Copy link
Member

This logic was present in the legacy promotion mechanisms and was overlooked in the git-commit directive.

@krancour krancour added this to the v0.9.0 milestone Sep 28, 2024
@krancour krancour self-assigned this Sep 28, 2024
@krancour krancour requested a review from a team as a code owner September 28, 2024 00:56
Copy link

netlify bot commented Sep 28, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 4cea0c7
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66f75441cc04560008c64247
😎 Deploy Preview https://deploy-preview-2590.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.09%. Comparing base (16e4674) to head (4cea0c7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/directives/git_commiter.go 28.57% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2590      +/-   ##
==========================================
- Coverage   51.10%   51.09%   -0.01%     
==========================================
  Files         282      282              
  Lines       20945    20950       +5     
==========================================
+ Hits        10703    10705       +2     
- Misses       9578     9580       +2     
- Partials      664      665       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this pull request to the merge queue Sep 28, 2024
Merged via the queue into akuity:main with commit 96c6ae8 Sep 28, 2024
22 of 24 checks passed
@krancour krancour deleted the krancour/git-commiter-fix branch September 28, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants