Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): unblock promotions when promotion directives are used #2592

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

Marvin9
Copy link
Contributor

@Marvin9 Marvin9 commented Sep 28, 2024

fixes #2587

@Marvin9 Marvin9 requested a review from a team as a code owner September 28, 2024 01:13
Copy link

netlify bot commented Sep 28, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 8c38998
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66f7582113ba380008c74e39
😎 Deploy Preview https://deploy-preview-2592.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Marvin9 Marvin9 self-assigned this Sep 28, 2024
@Marvin9 Marvin9 added this to the v0.9.0 milestone Sep 28, 2024
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.10%. Comparing base (16e4674) to head (8c38998).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2592   +/-   ##
=======================================
  Coverage   51.10%   51.10%           
=======================================
  Files         282      282           
  Lines       20945    20945           
=======================================
  Hits        10703    10703           
  Misses       9578     9578           
  Partials      664      664           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Thank you @Marvin9!

@krancour krancour added this pull request to the merge queue Sep 28, 2024
Merged via the queue into main with commit c21c4cf Sep 28, 2024
23 checks passed
@krancour krancour deleted the Marvin9/fix-allow-promotion-directives-promotion branch September 28, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: nothing is promotable if using promotion directives
2 participants