-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: keep track of promotion state in promotion status #2604
feat: keep track of promotion state in promotion status #2604
Conversation
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2604 +/- ##
==========================================
- Coverage 51.09% 51.05% -0.04%
==========================================
Files 282 282
Lines 20961 21007 +46
==========================================
+ Hits 10709 10726 +17
- Misses 9584 9614 +30
+ Partials 668 667 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No real objection from me. I wonder if in the future we continue to want to persist all state to the object (and not e.g. a sub-set which has to survive), but I think this concern can be addressed later.
Co-authored-by: Hidde Beydals <[email protected]>
@hiddeco it is best for you to review this one.
I know we had several offline conversations about whether this was worth avoiding or something we'd be forced to do.
Waiting for a PR to merge or close is the thing I ended up really needing this for.
Going back and looking at legacy code, even then, we never really had a way of doing this without storing the PR number in promotion status' metadata field.
fwiw, this is the last thing standing in the way of all of these directive-based examples passing:
https://github.com/krancour/kargo-examples/tree/for-v0.9.0
If you are generally unopposed to this, but wish to change some implementation details, please feel free to amend this PR to maximize the possibility that we cut a release candidate early in the day tomorrow.
Edit: A tangential benefit of this is it provides a little more visibility into what step is holding up a long-running promotion.