feat(ui): promotion directives wizard on stage creation step #2623

Marvin9 · 2024-10-01T21:32:46Z

Screen.Recording.2024-10-04.at.6.44.10.PM.mov

This PR simply utilises the JSON schema of directives configuration defined in backend.
rjsf is used to generate dynamic forms from JSON schemas - https://github.com/rjsf-team/react-jsonschema-form/tree/main/packages/antd

Signed-off-by: Remington Breeze <[email protected]>

…etails

> readonly view in promotions modal > create stage with promotion directive steps Signed-off-by: Mayursinh Sarvaiya <[email protected]>

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

Signed-off-by: Kent Rancourt <[email protected]>

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

…romotion-step-wizard

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

codecov · 2024-10-01T21:38:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.09%. Comparing base (8b2b7a4) to head (ca9e289).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2623   +/-   ##
=======================================
  Coverage   49.09%   49.09%           
=======================================
  Files         270      270           
  Lines       19342    19342           
=======================================
  Hits         9495     9495           
  Misses       9226     9226           
  Partials      621      621

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

krancour · 2024-10-03T00:42:01Z

There may still be time to get this into v0.9.0 if the merge conflicts are resolved.

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

…tep-wizard

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

netlify · 2024-10-04T18:59:09Z

✅ Deploy Preview for docs-kargo-io ready!

Name	Link
🔨 Latest commit	`ca9e289`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-kargo-io/deploys/670892e3362aa400080ee26a
😎 Deploy Preview	https://deploy-preview-2623--docs-kargo-io.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-10-04T18:59:09Z

✅ Deploy Preview for docs-kargo-akuity-io ready!

Name	Link
🔨 Latest commit	`ca9e289`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/670892e32409f80008eb27e1
😎 Deploy Preview	https://deploy-preview-2623.kargo.akuity.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

internal/directives/schemas/git-commit-config.json

…tep-wizard

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

Marvin9 · 2024-10-07T12:51:09Z

@krancour this one is ready. Should move the milestone to ~~1.0~~ Post GA?

krancour · 2024-10-08T21:05:25Z

@Marvin9 I think we can try and get this in v1.0.0.

Marvin9 · 2024-10-09T14:38:04Z

@krancour if you could take a UI look and @rpelczar can look at the code, we are good to merge this

…tep-wizard

rpelczar

A few minor comments, but apart from that LGTM!

ui/src/features/stage/promotion-steps-wizard/runner-form.module.less

ui/src/features/stage/promotion-steps-wizard/promotion-steps-wizard.tsx

rpelczar · 2024-10-09T22:38:13Z

ui/src/features/stage/create-stage.tsx

+                stringify(stageSpec?.spec?.promotionTemplate?.spec?.steps)
+              );
+            } catch (e) {
+              // explicitly ignore


Don't we want to inform the user that yaml is broken?

This is tricky. If we block user navigating if YAML is invalid, this becomes too aggressive. If we unblock user navigating and show error if YAML is invalid, we already lost broken YAML when we navigate. If we want to keep the broken YAML, this becomes complicated of syncing 2 source of truths (local state and YAML state).

So to simplify at this point, I think the use-case will either be complete raw YAML or complete wizard or correct YAML to wizard transformation. Broken YAML is rare case I think

ui/src/features/stage/create-stage.tsx

ui/src/features/common/layout/error-boundary.tsx

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

…e.less Co-authored-by: Rafal <[email protected]> Signed-off-by: Mayursinh Sarvaiya <[email protected]>

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

Marvin9 · 2024-10-10T16:12:10Z

@krancour not sure what to do with codecov CI failing

…tep-wizard

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

krancour · 2024-10-11T05:20:28Z

not sure what to do with codecov CI failing

Sorry for the late reply. It's informational and not required to pass.

Signed-off-by: Remington Breeze <[email protected]> Signed-off-by: Mayursinh Sarvaiya <[email protected]> Signed-off-by: Kent Rancourt <[email protected]> Co-authored-by: Remington Breeze <[email protected]> Co-authored-by: Kent Rancourt <[email protected]> Co-authored-by: Rafal <[email protected]>

rbreeze and others added 11 commits September 19, 2024 10:05

feat(ui): display promotion steps and YAML

90cf117

Signed-off-by: Remington Breeze <[email protected]>

Merge remote-tracking branch 'origin' into rbreeze/promo-directives-d…

513671d

…etails

feat(ui): promotion directives

8d082dd

> readonly view in promotions modal > create stage with promotion directive steps Signed-off-by: Mayursinh Sarvaiya <[email protected]>

fix(ui): crashing modal

d46e339

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

requested back end fix

6590335

Signed-off-by: Kent Rancourt <[email protected]>

Update internal/directives/simple_engine.go

490a3b6

Signed-off-by: Kent Rancourt <[email protected]>

fix(ui): promotion step logic update

6d5ff24

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

feat(ui): promotion directives wizard

de9b4a4

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

fix: json schema of directives

9943cce

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

Merge branch 'rbreeze/promo-directives-details' into Marvin9/extend-p…

fed525e

…romotion-step-wizard

chore(ui): design updates

3b08444

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

Marvin9 requested a review from a team as a code owner October 1, 2024 21:32

Marvin9 self-assigned this Oct 1, 2024

Marvin9 added kind/enhancement area/ui priority/normal labels Oct 1, 2024

chore(ui): imr

b9a334d

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

Base automatically changed from rbreeze/promo-directives-details to main October 2, 2024 16:16

krancour added this to the v0.9.0 milestone Oct 3, 2024

Marvin9 added 5 commits October 4, 2024 14:31

update

cbd55a4

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

Merge remote-tracking branch 'origin' into Marvin9/extend-promotion-s…

1c27fe8

…tep-wizard

codegen

cd549eb

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

chore(ui): updates

768dd1b

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

ux improvements

ca6f53c

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

Marvin9 commented Oct 4, 2024

View reviewed changes

internal/directives/schemas/git-commit-config.json Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin' into Marvin9/extend-promotion-s…

9699c22

…tep-wizard

Marvin9 added 4 commits October 4, 2024 18:24

feat(ui): UI change, replace drawer with inline form

9640788

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

fix(ui): ordering

3704b1b

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

fix(ui): yaml <-> wizard state

fe8abf0

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

chore(ui): update design

d56b6d2

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

Marvin9 modified the milestones: v0.9.0, Post-GA Oct 7, 2024

krancour modified the milestones: Post-GA, v1.0.0 Oct 8, 2024

Marvin9 requested review from rpelczar and krancour October 9, 2024 14:55

Merge remote-tracking branch 'origin' into Marvin9/extend-promotion-s…

5c879a0

…tep-wizard

rpelczar approved these changes Oct 9, 2024

View reviewed changes

Marvin9 and others added 3 commits October 10, 2024 12:24

chore(ui): review updates

bc0160f

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

Update ui/src/features/stage/promotion-steps-wizard/runner-form.modul…

2d48e9a

…e.less Co-authored-by: Rafal <[email protected]> Signed-off-by: Mayursinh Sarvaiya <[email protected]>

chore(ui): updates

5a7f0d4

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

Marvin9 force-pushed the Marvin9/extend-promotion-step-wizard branch from 91a005a to 5a7f0d4 Compare October 10, 2024 15:47

Marvin9 added 2 commits October 10, 2024 19:26

Merge remote-tracking branch 'origin' into Marvin9/extend-promotion-s…

3cd74ef

…tep-wizard

chore(ui): run codegen

ca9e289

Signed-off-by: Mayursinh Sarvaiya <[email protected]>

Marvin9 added this pull request to the merge queue Oct 11, 2024

Merged via the queue into main with commit 07849be Oct 11, 2024
21 checks passed

Marvin9 deleted the Marvin9/extend-promotion-step-wizard branch October 11, 2024 03:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ui): promotion directives wizard on stage creation step #2623

feat(ui): promotion directives wizard on stage creation step #2623

Marvin9 commented Oct 1, 2024 •

edited

Loading

codecov bot commented Oct 1, 2024 •

edited

Loading

krancour commented Oct 3, 2024

netlify bot commented Oct 4, 2024 •

edited

Loading

netlify bot commented Oct 4, 2024 •

edited

Loading

Marvin9 commented Oct 7, 2024 •

edited

Loading

krancour commented Oct 8, 2024

Marvin9 commented Oct 9, 2024

rpelczar left a comment

rpelczar Oct 9, 2024

Marvin9 Oct 10, 2024 •

edited

Loading

Marvin9 commented Oct 10, 2024

krancour commented Oct 11, 2024

feat(ui): promotion directives wizard on stage creation step #2623

feat(ui): promotion directives wizard on stage creation step #2623

Conversation

Marvin9 commented Oct 1, 2024 • edited Loading

codecov bot commented Oct 1, 2024 • edited Loading

Codecov Report

krancour commented Oct 3, 2024

netlify bot commented Oct 4, 2024 • edited Loading

✅ Deploy Preview for docs-kargo-io ready!

netlify bot commented Oct 4, 2024 • edited Loading

✅ Deploy Preview for docs-kargo-akuity-io ready!

Marvin9 commented Oct 7, 2024 • edited Loading

krancour commented Oct 8, 2024

Marvin9 commented Oct 9, 2024

rpelczar left a comment

Choose a reason for hiding this comment

rpelczar Oct 9, 2024

Choose a reason for hiding this comment

Marvin9 Oct 10, 2024 • edited Loading

Choose a reason for hiding this comment

Marvin9 commented Oct 10, 2024

krancour commented Oct 11, 2024

Marvin9 commented Oct 1, 2024 •

edited

Loading

codecov bot commented Oct 1, 2024 •

edited

Loading

netlify bot commented Oct 4, 2024 •

edited

Loading

netlify bot commented Oct 4, 2024 •

edited

Loading

Marvin9 commented Oct 7, 2024 •

edited

Loading

Marvin9 Oct 10, 2024 •

edited

Loading