-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: responsive versioned dropdown #3292
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Faeka Ansari <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I wonder if it would not be more useful to display a version for the "latest" version as well, or to at least mention which version is the latest, i.e. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3292 +/- ##
=======================================
Coverage 52.05% 52.05%
=======================================
Files 295 295
Lines 26695 26695
=======================================
Hits 13895 13895
Misses 12041 12041
Partials 759 759 ☔ View full report in Codecov by Sentry. |
Well... this is a bit complicated because I'm not sure we have any reasonable way to infer what branch docs.kargo.io currently points at. If we tried do something like take a guess that it points at the semantically greatest release-x.y branch, we'd end up being wrong anytime a release branch exists for an upcoming release. Two days ago, such a heuristic would have shown 1.1 docs and told people they were looking at 1.2. But I agree that it would be nice as long as we had a reasonable way to approach it. I think we should put a pin in this and come back to it when we have the luxury of time. I wouldn't want it to block the modest styling improvements in this PR. |
@fykaa this still doesn't look quite right on mobile... |
@krancour I gave the dropdown a fixed width on purpose because a dynamic width didn't seem appropriate for select dropdown. |
Signed-off-by: Faeka Ansari <[email protected]>
Should the version in the mobile sidebar be either at the top or the very bottom of the menu? |
Signed-off-by: Faeka Ansari <[email protected]>
1a0799f
to
b64796c
Compare
added version width and title
![image](https://private-user-images.githubusercontent.com/97490463/403564331-6dec3897-e94f-4b41-96e7-e3b598866ef8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyOTAyOTgsIm5iZiI6MTczOTI4OTk5OCwicGF0aCI6Ii85NzQ5MDQ2My80MDM1NjQzMzEtNmRlYzM4OTctZTk0Zi00YjQxLTk2ZTctZTNiNTk4ODY2ZWY4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDE2MDYzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI4ZTA1MjNjZjFjZjJkMDVmNTA5NDNiZGI5YzExZjEzMzEwN2FmMjQ4NjMwZGI4MGYzZGJjMTU2NGZjMGQzYWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ET0Xi_5s591PkHIKNTL_7X69uHzNfK7XdWqkxQWlYfs)
fixed dropdown component
![image](https://private-user-images.githubusercontent.com/97490463/403575311-072bed91-74f0-4425-b555-c1c199d728af.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyOTAyOTgsIm5iZiI6MTczOTI4OTk5OCwicGF0aCI6Ii85NzQ5MDQ2My80MDM1NzUzMTEtMDcyYmVkOTEtNzRmMC00NDI1LWI1NTUtYzFjMTk5ZDcyOGFmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDE2MDYzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU3ZjBkMWJiMmQzZTU1MTM1OGQyODJjMWEwYTg4MjYyMzQ0OWYzMzc5Mzc1OWIwZDY4MjNjZWYzOGU4ZGVkMzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.f6E599gW5EIbHOquzOsf4AGfhPY4P99sSYoyvjR6XYc)
![image](https://private-user-images.githubusercontent.com/97490463/403564522-6dd0ee05-3a02-420c-af9f-c62f6234e6b6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyOTAyOTgsIm5iZiI6MTczOTI4OTk5OCwicGF0aCI6Ii85NzQ5MDQ2My80MDM1NjQ1MjItNmRkMGVlMDUtM2EwMi00MjBjLWFmOWYtYzYyZjYyMzRlNmI2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDE2MDYzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQzODUzMDliZDRmMjg4NjFmNWFhZmViOGQ1OWVmMjIwZTc2ZmIzNWExY2YzZDEzNjliNzU1MTY5OWZmNTA5NjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.LlkrZv472G4ErdCQkHgoNCUAq-uI8f_1T1Mrm2FzFpc)
before:
after: