Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix how gRPC transport security is determined #201

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

ToanBarcelona1998
Copy link
Contributor

Description

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Run make format.
  • Run make lint.
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer and added meaningful comments.

@ToanBarcelona1998 ToanBarcelona1998 changed the title #fix grpc transport secure fix grpc transport secure Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b8385cc) 76.31% compared to head (4b59220) 77.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   76.31%   77.63%   +1.31%     
==========================================
  Files          26       26              
  Lines         684      684              
==========================================
+ Hits          522      531       +9     
+ Misses        162      153       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ToanBarcelona1998 ToanBarcelona1998 changed the title fix grpc transport secure - fix grpc transport secure Dec 8, 2023
@ToanBarcelona1998 ToanBarcelona1998 changed the title - fix grpc transport secure - fix: grpc transport secure Dec 8, 2023
@ToanBarcelona1998 ToanBarcelona1998 changed the title - fix: grpc transport secure fix: grpc transport secure Dec 8, 2023
@RiccardoM RiccardoM changed the title fix: grpc transport secure fix: fix how gRPC transport security is determined Dec 11, 2023
@RiccardoM RiccardoM merged commit 414bdbf into alan-sdk:main Dec 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants