Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes compilation issue #403 and improves error reporting #424

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

mikucionisaau
Copy link
Contributor

@mikucionisaau mikucionisaau commented Aug 27, 2024

Fixes #403 , similar to pr #423 but improved error reporting (e.g. #408).
Tested on g++-10/11/12/13/14, clang++-16, mingw-g++-13 (Debian testing)

The error reporting is better:

  • backward compatible (std::system_error inherits std::runtime_error, so catch(std::runtime_error&) works as before).
  • uses C++ standard exceptions.
  • uses platform specific error messages (for example "filepath: File not found" on Windows and "filepath: No such file or directory" on Linux).
  • includes the details like a filepath or a function name.

@mikucionisaau mikucionisaau changed the title Fixes issue #401 and improves error reporting Fixes compilation issue #403 and improves error reporting Aug 27, 2024
@alandefreitas
Copy link
Owner

alandefreitas commented Aug 28, 2024

Looks good to me. It needs to be rebased, though.

@mikucionisaau
Copy link
Contributor Author

@alandefreitas done :-)

@alandefreitas alandefreitas merged commit 4ab073b into alandefreitas:master Sep 4, 2024
@mikucionisaau mikucionisaau deleted the fix-403 branch September 5, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation error gcc/g++ 13.2.1 clang 17.0.6 cmake 3.29.2
2 participants