-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost version #2013
Boost version #2013
Conversation
Reviewer's Guide by SourceryThis PR updates the CI workflow and dependency management system. The main changes include switching to uv for package management, streamlining the CI workflow, updating dependencies, and simplifying version management by removing the separate version file. Architecture diagram for updated CI workflowgraph TD;
A[CI Workflow] -->|uses| B[actions/cache@v4];
A -->|uses| C[codecov/[email protected]];
A -->|uses| D[actions/setup-python@v5];
B -->|caches| E[uv dependencies];
C -->|uploads| F[Coverage Reports];
D -->|sets up| G[Python Environment];
Updated class diagram for setup.pyclassDiagram
class Setup {
-list~str~ INSTALL_REQUIRES
-list~tuple~ CHOOSE_INSTALL_REQUIRES
+list~str~ get_install_requirements(list~str~ install_requires, list~tuple~ choose_install_requires)
+str choose_requirement(tuple~str~ mains, str secondary)
}
note for Setup "Removed get_version method and version attribute"
Updated class diagram for version managementclassDiagram
class CheckVersion {
-str current_version
}
class Serialization {
-str __version__
}
note for CheckVersion "Updated import for current_version"
note for Serialization "Updated import for __version__"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes - here's some feedback:
Overall Comments:
- The version handling code has been removed from setup.py and _version.py, but the new location of version definition isn't shown in the diff. Please clarify where and how the version is now being managed.
- The codecov.yaml validation check was removed from the CI workflow. Was this intentional, and if so, what's the reasoning behind removing this validation step?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2013 +/- ##
=========================================
+ Coverage 0 90.32% +90.32%
=========================================
Files 0 47 +47
Lines 0 7558 +7558
=========================================
+ Hits 0 6827 +6827
- Misses 0 731 +731 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Update CI configuration to streamline dependency installation and version management. Remove version file and refactor version handling to use direct imports. Simplify and consolidate dependency installation steps in the CI workflow.
Enhancements:
CI: