-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ToTensorv2 for multiple images #2014
Conversation
Reviewer's Guide by SourceryThis PR extends the ToTensorV2 transform to handle lists of images by adding a new apply_to_images method and updating the targets property to include the 'images' key. The implementation iterates through the list of images and applies the existing single-image transformation to each image. Updated class diagram for ToTensorV2classDiagram
class ToTensorV2 {
- transpose_mask: bool
- p: float
- always_apply: bool
+ apply(img: np.ndarray, **params: Any) torch.Tensor
+ apply_to_images(images: list[np.ndarray], **params: Any) list[torch.Tensor]
+ apply_to_mask(mask: np.ndarray, **params: Any) torch.Tensor
+ targets() dict[str, Any]
}
note for ToTensorV2 "Added apply_to_images method and updated targets property to handle lists of images."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @loicmagne - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please add test coverage for the new
apply_to_images
functionality to verify it correctly handles lists of images
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@loicmagne Thanks! |
Thanks for the quick merge @ternaus! |
The current behavior is the following:
Is that an expected behavior? I added a handler on the
ToTensorV2
class to also transform lists of images, let me know if I'm missing somethingSummary by Sourcery
New Features: