Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ToTensorv2 for multiple images #2014

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

loicmagne
Copy link
Contributor

@loicmagne loicmagne commented Oct 23, 2024

The current behavior is the following:

>>> import numpy as np
>>> import albumentations as A
>>> from albumentations.pytorch import ToTensorV2
>>> 
>>> t = A.Compose([
...     ToTensorV2(),
... ])
>>> x = [np.zeros((224, 224, 3))]
>>> x = t(images=x)['images']
>>> 
>>> print(type(x[0]))
<class 'numpy.ndarray'>

Is that an expected behavior? I added a handler on the ToTensorV2 class to also transform lists of images, let me know if I'm missing something

Summary by Sourcery

New Features:

  • Add support for transforming lists of images to tensors using ToTensorV2.

Copy link
Contributor

sourcery-ai bot commented Oct 23, 2024

Reviewer's Guide by Sourcery

This PR extends the ToTensorV2 transform to handle lists of images by adding a new apply_to_images method and updating the targets property to include the 'images' key. The implementation iterates through the list of images and applies the existing single-image transformation to each image.

Updated class diagram for ToTensorV2

classDiagram
    class ToTensorV2 {
        - transpose_mask: bool
        - p: float
        - always_apply: bool
        + apply(img: np.ndarray, **params: Any) torch.Tensor
        + apply_to_images(images: list[np.ndarray], **params: Any) list[torch.Tensor]
        + apply_to_mask(mask: np.ndarray, **params: Any) torch.Tensor
        + targets() dict[str, Any]
    }
    note for ToTensorV2 "Added apply_to_images method and updated targets property to handle lists of images."
Loading

File-Level Changes

Change Details Files
Added support for transforming lists of images in ToTensorV2
  • Added new apply_to_images method that processes a list of numpy arrays into a list of torch tensors
  • Updated targets property to include 'images' key mapping to the new apply_to_images method
  • Maintained existing single image transformation logic in the apply method
albumentations/pytorch/transforms.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @loicmagne - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please add test coverage for the new apply_to_images functionality to verify it correctly handles lists of images
Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

albumentations/pytorch/transforms.py Show resolved Hide resolved
albumentations/pytorch/transforms.py Show resolved Hide resolved
albumentations/pytorch/transforms.py Show resolved Hide resolved
@ternaus ternaus merged commit 96bb6ee into albumentations-team:main Oct 23, 2024
14 checks passed
@ternaus
Copy link
Collaborator

ternaus commented Oct 23, 2024

@loicmagne Thanks!

@loicmagne
Copy link
Contributor Author

Thanks for the quick merge @ternaus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants