-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handle empty array #2135
Fix handle empty array #2135
Conversation
Reviewer's Guide by SourceryThis PR modifies the Class diagram for handle_empty_array decorator changesclassDiagram
class handle_empty_array {
+handle_empty_array(param_name: str) Callable[[F], F]
}
class wrapper {
+wrapper(*args: Any, **kwargs: Any) Any
}
handle_empty_array --> wrapper : uses
note for handle_empty_array "Decorator now accepts a parameter name to check for emptiness."
note for wrapper "Wrapper function checks if the specified parameter is empty."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2135 +/- ##
=========================================
+ Coverage 0 90.34% +90.34%
=========================================
Files 0 48 +48
Lines 0 7926 +7926
=========================================
+ Hits 0 7161 +7161
- Misses 0 765 +765 ☔ View full report in Codecov by Sentry. |
Fixes: #2133
Summary by Sourcery
Bug Fixes: