Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handle empty array #2135

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Fix handle empty array #2135

merged 2 commits into from
Nov 11, 2024

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Nov 11, 2024

Fixes: #2133

Summary by Sourcery

Bug Fixes:

  • Fix handling of empty arrays in various geometric and augmentation functions by specifying the parameter name in the handle_empty_array decorator.

Copy link
Contributor

sourcery-ai bot commented Nov 11, 2024

Reviewer's Guide by Sourcery

This PR modifies the handle_empty_array decorator to accept a parameter name as an argument, making it more robust and explicit in handling empty arrays for specific function parameters. The changes involve updating all existing decorator usages across the codebase to specify which parameter should be checked for emptiness.

Class diagram for handle_empty_array decorator changes

classDiagram
    class handle_empty_array {
        +handle_empty_array(param_name: str) Callable[[F], F]
    }

    class wrapper {
        +wrapper(*args: Any, **kwargs: Any) Any
    }

    handle_empty_array --> wrapper : uses

    note for handle_empty_array "Decorator now accepts a parameter name to check for emptiness."
    note for wrapper "Wrapper function checks if the specified parameter is empty."
Loading

File-Level Changes

Change Details Files
Refactored the handle_empty_array decorator to be more explicit and robust
  • Modified decorator to accept a parameter name argument
  • Added support for both positional and keyword arguments
  • Added validation to ensure the specified parameter exists
  • Maintained the original empty array check functionality
albumentations/augmentations/utils.py
Updated all existing handle_empty_array decorator usage
  • Added explicit parameter names to all decorator calls
  • Updated bboxes-related functions to use @handle_empty_array('bboxes')
  • Updated keypoints-related functions to use @handle_empty_array('keypoints')
  • Updated points-related function to use @handle_empty_array('points')
albumentations/augmentations/geometric/functional.py
albumentations/core/bbox_utils.py
albumentations/augmentations/dropout/functional.py
albumentations/augmentations/crops/functional.py
albumentations/augmentations/functional.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

albumentations/augmentations/utils.py Show resolved Hide resolved
albumentations/augmentations/utils.py Show resolved Hide resolved
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 94.64286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.34%. Comparing base (b1a79c2) to head (6fafcf1).
Report is 267 commits behind head on main.

Files with missing lines Patch % Lines
albumentations/augmentations/utils.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2135       +/-   ##
=========================================
+ Coverage      0   90.34%   +90.34%     
=========================================
  Files         0       48       +48     
  Lines         0     7926     +7926     
=========================================
+ Hits          0     7161     +7161     
- Misses        0      765      +765     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ternaus ternaus merged commit 4cfe99f into main Nov 11, 2024
16 checks passed
@ternaus ternaus deleted the fix_handle_empty_array branch November 11, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bbox_utils.convert_bboxes_to_albumentations() not working
1 participant