-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sharpen #2150
Update sharpen #2150
Conversation
Reviewer's Guide by SourceryThis PR enhances the Sharpen transform by introducing two different sharpening methods: a traditional kernel-based approach using Laplacian operator and a new Gaussian interpolation method. The implementation includes updated parameters, improved documentation, and a new functional method for Gaussian sharpening. Updated class diagram for Sharpen transformclassDiagram
class Sharpen {
+tuple[float, float] alpha
+tuple[float, float] lightness
+Literal["kernel", "gaussian"] method
+int kernel_size
+float sigma
+get_params() dict[str, Any]
+apply(np.ndarray img, float alpha, np.ndarray|None sharpening_matrix, **params) np.ndarray
+get_transform_init_args_names() tuple[str, ...]
}
note for Sharpen "Added method, kernel_size, and sigma attributes. Updated apply and get_params methods."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2150 +/- ##
=========================================
+ Coverage 0 90.16% +90.16%
=========================================
Files 0 48 +48
Lines 0 8267 +8267
=========================================
+ Hits 0 7454 +7454
- Misses 0 813 +813 ☔ View full report in Codecov by Sentry. |
Addresses: #2110
Summary by Sourcery
Enhance the Sharpen transform by adding support for a Gaussian interpolation method alongside the existing kernel-based method. Update the transform's parameters to accommodate the new method, including options for kernel size and sigma. Implement a new function, sharpen_gaussian, to apply the Gaussian sharpening technique.
New Features:
Enhancements: