-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update motion blur #2154
Update motion blur #2154
Conversation
Reviewer's Guide by SourceryThis PR enhances the MotionBlur transform by introducing more precise control over motion blur effects. The implementation replaces the previous random line-based kernel generation with a more sophisticated directional kernel system that offers control over angle, direction, and position of the blur effect. Updated class diagram for MotionBlurclassDiagram
class MotionBlur {
-int|tuple[int, int] blur_limit
-bool allow_shifted
-tuple[float, float] angle_range
-tuple[float, float] direction_range
-float p
+apply(np.ndarray img, np.ndarray kernel, **params: Any) np.ndarray
+get_transform_init_args_names() tuple[str, ...]
+get_params() dict[str, Any]
}
class Blur {
<<abstract>>
}
MotionBlur --|> Blur
note for MotionBlur "Enhanced with angle_range and direction_range for directional blur control"
Class diagram for create_motion_kernel functionclassDiagram
class create_motion_kernel {
+np.ndarray create_motion_kernel(int kernel_size, float angle, float direction, bool allow_shifted, Random random_state)
}
note for create_motion_kernel "Generates a directional motion blur kernel with angle and direction control"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2154 +/- ##
=========================================
+ Coverage 0 90.34% +90.34%
=========================================
Files 0 48 +48
Lines 0 8399 +8399
=========================================
+ Hits 0 7588 +7588
- Misses 0 811 +811 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Addresses: #2101
Summary by Sourcery
Enhancements: