Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SafeRotate #2246

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Updated SafeRotate #2246

merged 1 commit into from
Jan 7, 2025

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Jan 7, 2025

Changed default Border mode to constant

Summary by Sourcery

Enhancements:

  • Set the default border_mode to cv2.BORDER_CONSTANT in SafeRotate transform.

Copy link
Contributor

sourcery-ai bot commented Jan 7, 2025

Reviewer's Guide by Sourcery

Changed default border_mode to cv2.BORDER_CONSTANT in SafeRotate.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Changed default border mode
  • Changed border_mode from cv2.BORDER_REFLECT_101 to cv2.BORDER_CONSTANT.
  • Removed value and mask_value parameters.
  • Added fill parameter with a default value of 0
albumentations/augmentations/geometric/rotate.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

  • This changes the default border mode from BORDER_REFLECT_101 to BORDER_CONSTANT which is a breaking change. Please provide justification for this change and document it appropriately.
  • The removal of 'value' and 'mask_value' parameters needs explanation, especially since they're typically used with BORDER_CONSTANT mode.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ternaus ternaus merged commit db76830 into main Jan 7, 2025
14 checks passed
@ternaus ternaus deleted the update_safe_rotate branch January 7, 2025 18:30
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (b1a79c2) to head (0641935).
Report is 353 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2246       +/-   ##
=========================================
+ Coverage      0   89.79%   +89.79%     
=========================================
  Files         0       50       +50     
  Lines         0     9044     +9044     
=========================================
+ Hits          0     8121     +8121     
- Misses        0      923      +923     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant