Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update random snow #2257

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Update random snow #2257

merged 3 commits into from
Jan 7, 2025

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Jan 7, 2025

Summary by Sourcery

Replace deprecated snow_point_lower and snow_point_upper parameters with snow_point_range in RandomSnow transform.

Enhancements:

  • Simplified the RandomSnow transform initialization by removing deprecated parameters.

Tests:

  • Removed tests for deprecated snow_point_lower and snow_point_upper parameters.

Copy link
Contributor

sourcery-ai bot commented Jan 7, 2025

Reviewer's Guide by Sourcery

This pull request refactors the RandomSnow augmentation to use snow_point_range instead of snow_point_lower and snow_point_upper.

Class diagram showing changes to InitSchema class

classDiagram
    class InitSchema {
        +tuple[float, float] snow_point_range
        +float brightness_coeff
        +str method
        -validate_ranges()
    }
    note for InitSchema "Removed snow_point_lower and snow_point_upper fields
Simplified to use snow_point_range tuple"
Loading

State diagram showing RandomSnow parameter validation flow

stateDiagram-v2
    [*] --> ValidateInput
    ValidateInput --> CheckSnowPointRange
    CheckSnowPointRange --> ValidRange: 0 < range[0] <= range[1] < 1
    CheckSnowPointRange --> Error: Invalid range
    ValidRange --> [*]
    Error --> [*]
Loading

File-Level Changes

Change Details Files
Replaced snow_point_lower and snow_point_upper with snow_point_range
  • Removed snow_point_lower and snow_point_upper parameters from RandomSnow.__init__
  • Removed validation and deprecation warnings related to snow_point_lower and snow_point_upper from InitSchema
  • Removed tests related to snow_point_lower and snow_point_upper from test_random_snow_initialization
albumentations/augmentations/transforms.py
tests/test_transforms.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

albumentations/augmentations/transforms.py Show resolved Hide resolved
tests/test_transforms.py Show resolved Hide resolved
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.89%. Comparing base (b1a79c2) to head (d48050a).
Report is 363 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2257       +/-   ##
=========================================
+ Coverage      0   89.89%   +89.89%     
=========================================
  Files         0       50       +50     
  Lines         0     8946     +8946     
=========================================
+ Hits          0     8042     +8042     
- Misses        0      904      +904     
Flag Coverage Δ
ubuntu-py3.12 89.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ternaus ternaus merged commit 8148e6a into main Jan 7, 2025
16 checks passed
@ternaus ternaus deleted the update_random_snow branch January 7, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant