-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update random snow #2257
Update random snow #2257
Conversation
Reviewer's Guide by SourceryThis pull request refactors the Class diagram showing changes to InitSchema classclassDiagram
class InitSchema {
+tuple[float, float] snow_point_range
+float brightness_coeff
+str method
-validate_ranges()
}
note for InitSchema "Removed snow_point_lower and snow_point_upper fields
Simplified to use snow_point_range tuple"
State diagram showing RandomSnow parameter validation flowstateDiagram-v2
[*] --> ValidateInput
ValidateInput --> CheckSnowPointRange
CheckSnowPointRange --> ValidRange: 0 < range[0] <= range[1] < 1
CheckSnowPointRange --> Error: Invalid range
ValidRange --> [*]
Error --> [*]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2257 +/- ##
=========================================
+ Coverage 0 89.89% +89.89%
=========================================
Files 0 50 +50
Lines 0 8946 +8946
=========================================
+ Hits 0 8042 +8042
- Misses 0 904 +904
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Replace deprecated
snow_point_lower
andsnow_point_upper
parameters withsnow_point_range
inRandomSnow
transform.Enhancements:
RandomSnow
transform initialization by removing deprecated parameters.Tests:
snow_point_lower
andsnow_point_upper
parameters.