-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated random rain #2258
updated random rain #2258
Conversation
Reviewer's Guide by SourceryThis PR updates the Class diagram showing changes to RandomRain transformclassDiagram
class RandomRain {
<<ImageOnlyTransform>>
-slant_range: tuple[int, int]
-drop_length: int
-drop_width: int
-drop_color: tuple[int, int, int]
-drop_count: int
-brightness_coefficient: float
-rain_type: RainMode
}
class InitSchema {
<<BaseTransformInitSchema>>
+slant_range: tuple[float, float]
+drop_length: int
+drop_width: int
+drop_color: tuple[int, int, int]
+drop_count: int
+brightness_coefficient: float
+rain_type: RainMode
}
note for InitSchema "Removed deprecated slant_lower and slant_upper
Added validation for slant_range bounds"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2258 +/- ##
=========================================
+ Coverage 0 89.87% +89.87%
=========================================
Files 0 50 +50
Lines 0 8929 +8929
=========================================
+ Hits 0 8025 +8025
- Misses 0 904 +904
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Refactor the
RandomRain
transform to useslant_range
instead ofslant_lower
andslant_upper
.Enhancements:
slant_lower
andslant_upper
parameters withslant_range
in theRandomRain
transform.Tests:
slant_lower
andslant_upper
parameters.