Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated random rain #2258

Merged
merged 1 commit into from
Jan 7, 2025
Merged

updated random rain #2258

merged 1 commit into from
Jan 7, 2025

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Jan 7, 2025

Summary by Sourcery

Refactor the RandomRain transform to use slant_range instead of slant_lower and slant_upper.

Enhancements:

  • Replace the deprecated slant_lower and slant_upper parameters with slant_range in the RandomRain transform.

Tests:

  • Remove tests for the deprecated slant_lower and slant_upper parameters.

Copy link
Contributor

sourcery-ai bot commented Jan 7, 2025

Reviewer's Guide by Sourcery

This PR updates the RandomRain transform to use slant_range instead of slant_lower and slant_upper. It removes the deprecated slant_lower and slant_upper parameters and updates the InitSchema to only use slant_range. The tests for the deprecated parameters are also removed.

Class diagram showing changes to RandomRain transform

classDiagram
    class RandomRain {
        <<ImageOnlyTransform>>
        -slant_range: tuple[int, int]
        -drop_length: int
        -drop_width: int
        -drop_color: tuple[int, int, int]
        -drop_count: int
        -brightness_coefficient: float
        -rain_type: RainMode
    }

    class InitSchema {
        <<BaseTransformInitSchema>>
        +slant_range: tuple[float, float]
        +drop_length: int
        +drop_width: int
        +drop_color: tuple[int, int, int]
        +drop_count: int
        +brightness_coefficient: float
        +rain_type: RainMode
    }
    note for InitSchema "Removed deprecated slant_lower and slant_upper
Added validation for slant_range bounds"
Loading

File-Level Changes

Change Details Files
Updated RandomRain transform to use slant_range.
  • Removed deprecated slant_lower and slant_upper parameters.
  • Updated InitSchema to use slant_range with validation.
  • Removed validation and deprecation warnings for slant_lower and slant_upper.
albumentations/augmentations/transforms.py
Removed tests for deprecated slant_lower and slant_upper parameters.
  • Removed tests that checked the initialization of RandomRain with slant_lower and slant_upper parameters.
tests/test_transforms.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

albumentations/augmentations/transforms.py Show resolved Hide resolved
tests/test_transforms.py Show resolved Hide resolved
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (b1a79c2) to head (430f88b).
Report is 364 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2258       +/-   ##
=========================================
+ Coverage      0   89.87%   +89.87%     
=========================================
  Files         0       50       +50     
  Lines         0     8929     +8929     
=========================================
+ Hits          0     8025     +8025     
- Misses        0      904      +904     
Flag Coverage Δ
ubuntu-py3.12 89.87% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ternaus ternaus merged commit 704fb34 into main Jan 7, 2025
16 checks passed
@ternaus ternaus deleted the update_random_rain branch January 7, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant