-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated random fog #2259
updated random fog #2259
Conversation
Reviewer's Guide by SourceryThis pull request refactors the Class diagram showing changes to RandomFog transformclassDiagram
class RandomFog {
+__init__(alpha_coef: float, fog_coef_range: tuple[float, float], p: float)
}
class InitSchema {
+fog_coef_range: tuple[float, float]
+alpha_coef: float
}
note for InitSchema "Removed deprecated fog_coef_lower and fog_coef_upper fields"
note for InitSchema "fog_coef_range is now the primary way to specify fog coefficients"
RandomFog -- InitSchema
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding tests for the current RandomFog initialization scenarios with fog_coef_range to maintain test coverage
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2259 +/- ##
=========================================
+ Coverage 0 89.85% +89.85%
=========================================
Files 0 50 +50
Lines 0 8915 +8915
=========================================
+ Hits 0 8011 +8011
- Misses 0 904 +904
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Replace the deprecated
fog_coef_lower
andfog_coef_upper
parameters withfog_coef_range
in theRandomFog
transform.Enhancements:
RandomFog
transform initialization by removing deprecated parameters.Tests:
RandomFog
transform.