Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated random fog #2259

Merged
merged 1 commit into from
Jan 7, 2025
Merged

updated random fog #2259

merged 1 commit into from
Jan 7, 2025

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Jan 7, 2025

Summary by Sourcery

Replace the deprecated fog_coef_lower and fog_coef_upper parameters with fog_coef_range in the RandomFog transform.

Enhancements:

  • Simplified the RandomFog transform initialization by removing deprecated parameters.

Tests:

  • Removed deprecated parameter tests for the RandomFog transform.

Copy link
Contributor

sourcery-ai bot commented Jan 7, 2025

Reviewer's Guide by Sourcery

This pull request refactors the RandomFog transform to use fog_coef_range instead of the deprecated fog_coef_lower and fog_coef_upper parameters.

Class diagram showing changes to RandomFog transform

classDiagram
    class RandomFog {
        +__init__(alpha_coef: float, fog_coef_range: tuple[float, float], p: float)
    }
    class InitSchema {
        +fog_coef_range: tuple[float, float]
        +alpha_coef: float
    }
    note for InitSchema "Removed deprecated fog_coef_lower and fog_coef_upper fields"
    note for InitSchema "fog_coef_range is now the primary way to specify fog coefficients"
    RandomFog -- InitSchema
Loading

File-Level Changes

Change Details Files
Removed deprecated fog_coef_lower and fog_coef_upper parameters.
  • Removed the deprecated parameters from the RandomFog class.
  • Removed tests associated to the deprecated parameters.
  • Updated the class schema to only include the fog_coef_range parameter.
  • Removed the logic that handled the deprecated parameters from the schema validation and initialization.
  • Removed tests that specifically targeted the deprecated parameters and their interaction with the new fog_coef_range parameter.
albumentations/augmentations/transforms.py
tests/test_transforms.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding tests for the current RandomFog initialization scenarios with fog_coef_range to maintain test coverage
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (b1a79c2) to head (bd9cd55).
Report is 365 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2259       +/-   ##
=========================================
+ Coverage      0   89.85%   +89.85%     
=========================================
  Files         0       50       +50     
  Lines         0     8915     +8915     
=========================================
+ Hits          0     8011     +8011     
- Misses        0      904      +904     
Flag Coverage Δ
ubuntu-py3.12 89.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ternaus ternaus merged commit 723c0a3 into main Jan 7, 2025
16 checks passed
@ternaus ternaus deleted the update_random_fog branch January 7, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant