Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated GaussNoise and deleted traget_as_params #2268

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Updated GaussNoise and deleted traget_as_params #2268

merged 1 commit into from
Jan 8, 2025

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Jan 8, 2025

  • Updated GaussNoise
  • Removed get_params_dependent_on_targets

Summary by Sourcery

Update the Gaussian noise implementation and remove deprecated parameters.

Bug Fixes:

  • Fix the incorrect behavior of the GaussNoise transform when using legacy parameters.

Enhancements:

  • Simplify the GaussNoise transform by removing deprecated var_limit and mean parameters and using std_range and mean_range instead.

Copy link
Contributor

sourcery-ai bot commented Jan 8, 2025

Reviewer's Guide by Sourcery

This pull request updates the GaussNoise transform and removes the deprecated get_params_dependent_on_targets method.

Class diagram showing GaussNoise transform changes

classDiagram
    class GaussNoise {
        +std_range: tuple[float, float]
        +mean_range: tuple[float, float]
        +per_channel: bool
        +noise_scale_factor: float
        +__init__(std_range, mean_range, per_channel, noise_scale_factor)
        +apply(img, sigma, mean, max_value)
        +get_params_dependent_on_data()
    }
    note for GaussNoise "Removed deprecated var_limit and mean parameters
Simplified noise generation logic"
Loading

Class diagram showing Transform interface changes

classDiagram
    class BasicTransform {
        +__call__(*args, force_apply, **kwargs)
        +targets_as_params()
    }
    note for BasicTransform "Removed deprecated get_params_dependent_on_targets method
Simplified parameter handling in __call__"
Loading

File-Level Changes

Change Details Files
Updated GaussNoise to use std_range instead of var_limit and mean_range instead of mean.
  • Removed deprecated var_limit parameter.
  • Removed deprecated mean parameter.
  • Removed logic for handling deprecated parameters.
  • Updated documentation to reflect the changes.
  • Simplified the get_params_dependent_on_data method by removing the logic for handling deprecated parameters.
  • Standardized the sampling of standard deviation to align with torchvision/kornia.
albumentations/augmentations/transforms.py
Removed the deprecated get_params_dependent_on_targets method and associated logic.
  • Removed the get_params_dependent_on_targets method.
  • Removed the targets_as_params property.
  • Removed the logic in the __call__ method that used the get_params_dependent_on_targets method and targets_as_params property.
albumentations/core/transforms_interface.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.82%. Comparing base (b1a79c2) to head (02bb6dd).
Report is 374 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2268       +/-   ##
=========================================
+ Coverage      0   89.82%   +89.82%     
=========================================
  Files         0       50       +50     
  Lines         0     8797     +8797     
=========================================
+ Hits          0     7902     +7902     
- Misses        0      895      +895     
Flag Coverage Δ
ubuntu-py3.12 89.82% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ternaus ternaus merged commit e4d6cce into main Jan 8, 2025
16 checks passed
@ternaus ternaus deleted the cleanup branch January 8, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant