-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated GaussNoise and deleted traget_as_params #2268
Conversation
Reviewer's Guide by SourceryThis pull request updates the Class diagram showing GaussNoise transform changesclassDiagram
class GaussNoise {
+std_range: tuple[float, float]
+mean_range: tuple[float, float]
+per_channel: bool
+noise_scale_factor: float
+__init__(std_range, mean_range, per_channel, noise_scale_factor)
+apply(img, sigma, mean, max_value)
+get_params_dependent_on_data()
}
note for GaussNoise "Removed deprecated var_limit and mean parameters
Simplified noise generation logic"
Class diagram showing Transform interface changesclassDiagram
class BasicTransform {
+__call__(*args, force_apply, **kwargs)
+targets_as_params()
}
note for BasicTransform "Removed deprecated get_params_dependent_on_targets method
Simplified parameter handling in __call__"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2268 +/- ##
=========================================
+ Coverage 0 89.82% +89.82%
=========================================
Files 0 50 +50
Lines 0 8797 +8797
=========================================
+ Hits 0 7902 +7902
- Misses 0 895 +895
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GaussNoise
get_params_dependent_on_targets
Summary by Sourcery
Update the Gaussian noise implementation and remove deprecated parameters.
Bug Fixes:
GaussNoise
transform when using legacy parameters.Enhancements:
GaussNoise
transform by removing deprecatedvar_limit
andmean
parameters and usingstd_range
andmean_range
instead.