Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: walletconnect sign raw #1371

Closed
wants to merge 1 commit into from
Closed

Conversation

jakehobbs
Copy link
Member

@jakehobbs jakehobbs commented Feb 18, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on updating the signMessage method in the WalletClientSigner class to handle different message formats, specifically ensuring compatibility with Wallet Connect by supporting string messages and converting raw byte messages to hex.

Detailed summary

  • Modified the signMessage method to handle messages as strings.
  • Added a conditional check to determine the message format:
    • If the message is a string, it is used directly.
    • If the message has a raw property that is a string, it is used.
    • Otherwise, raw is converted to hex using bytesToHex.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 0:35am
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 0:35am

Copy link

graphite-app bot commented Feb 18, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@jakehobbs
Copy link
Member Author

Closing this as it's not actually the issue.

@jakehobbs jakehobbs closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant