-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add v2.0.0 deployments #327
Conversation
Contract sizes: | Contract | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
| AccountFactory | 6,661 | 7,135 | 17,915 | 42,017 |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| AllowlistModule | 10,262 | 10,289 | 14,314 | 38,863 |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| ExecutionInstallDelegate | 5,947 | 5,993 | 18,629 | 43,159 |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| ModularAccount | 23,273 | 23,672 | 1,303 | 25,480 |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| NativeTokenLimitModule | 5,093 | 5,120 | 19,483 | 44,032 |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| PaymasterGuardModule | 2,097 | 2,124 | 22,479 | 47,028 |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| SemiModularAccount7702 | 23,741 | 24,133 | 835 | 25,019 |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| SemiModularAccountBytecode | 24,223 | 24,622 | 353 | 24,530 |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| SemiModularAccountStorageOnly | 24,756 | 25,155 | -180 | 23,997 |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| SingleSignerValidationModule | 3,976 | 4,003 | 20,600 | 45,149 |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| TimeRangeModule | 2,504 | 2,531 | 22,072 | 46,621 |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| WebAuthnValidationModule | 9,462 | 9,489 | 15,114 | 39,663 | Code coverage: |
Motivation
Track deployments of Modular Account v2.0.0.
Solution
Commit the script runs for the deployment and staking scripts:
DeployStandalones.s.sol
DeployAccounts.s.sol
DeploySmaStorage.s.sol
DeployFactory.s.sol
StakeFactory.s.sol
For the following networks:
Add a
Deployments.md
file to thedeployments/v2/
folder. This is a simplified format compared to the format used in v1, and does not contain explorer links. We should probably standardize this in the future across v1 and v2.Also correct some minor things (that don't affect the generated bytecode):
optimized-build-standalone
profile to 10M. This setting was at 10B earlier, and Etherscan contract verification does not accept any setting above 10M. Thankfully, this does not result in any bytecode difference.SEMI_MODULAR_ACCOUNT_STORAGE_ONLY_IMPL_SALT