Exclude a few more things from published crates #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bundled C library in the ext directory is only used by internal libqoi that isn't published on crates.io, and test_gen.rs tests libqoi (which again isn't published). The pdf doc isn't used for the build of the published crate either, so exclude this as well. Pointed out by Fabio Valentini in https://bugzilla.redhat.com/show_bug.cgi?id=2233787
|
Agreed re: the doc folder. Re: libqoi and test_gen.rs, I'm unsure about that, if you remove those, you won't be able to simply run
Not quite - test_gen.rs tests that the following roundtrips successfully for a bunch of generated samples:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bundled C library in the ext directory is only used by internal libqoi that isn't published on crates.io, and test_gen.rs tests libqoi (which again isn't published).
The pdf doc isn't used for the build of the published crate either, so exclude this as well.
Pointed out by Fabio Valentini in
https://bugzilla.redhat.com/show_bug.cgi?id=2233787