Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compileFromRust API #44

Merged
merged 3 commits into from
Dec 15, 2023
Merged

compileFromRust API #44

merged 3 commits into from
Dec 15, 2023

Conversation

brentongunning
Copy link
Contributor

2 changes

  • support passing src and deps as [string, string][] instead of Map<string, string> b/c easier on rust side (serde_v8 lib doesn't support maps so would have to do low-level)
  • foreign abis (for import pkg://...) are passed in binary and parsed on the compile side making the compiler the single place for all code generation.

@brentongunning
Copy link
Contributor Author

Tests failing for create-aldea

@brentongunning
Copy link
Contributor Author

Doesn't seem related, but should be fixed

@brentongunning brentongunning merged commit fed4463 into main Dec 15, 2023
0 of 2 checks passed
@brentongunning brentongunning deleted the rust-node-api branch December 15, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brentongunning