new layouts for generic blog and articles #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebrunel
reviewed
Oct 30, 2023
website/components/mobile-nav.vue
Outdated
There was a problem hiding this comment.
I assume this isn't finished yet as it just looks like a copy of the footer?
Not too sure where you're headed with this, but just wanted to say that generally I prefer using pure css solutions for changing ui for mobile/desktop.
There was a problem hiding this comment.
I created a separated component cause I didn't know how to implement it :V But the idea is to use CSS. I wanted to have the code done so we just copy it later. If you see in small devices, the nav disappears. I put any icon. This should have the function of opening the nav in full screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.