Fix microarchitecture specific code in common code paths #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #448 +/- ##
=======================================
Coverage 84.83% 84.83%
=======================================
Files 49 49
Lines 11738 11738
Branches 2206 2206
=======================================
Hits 9958 9958
Misses 1780 1780 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you for catching this. |
skirpichev
approved these changes
Oct 30, 2023
| # We replace config.guess with configfsf.guess to avoid microarchitecture | ||
| # specific code in common code. | ||
| rm config.guess && mv configfsf.guess config.guess && chmod +x config.guess | ||
| ./configure --enable-fat && make -j4 && make install && cd ../ |
There was a problem hiding this comment.
I think you could use just --build=$(./configfsf.guess). But anyway, this workaround probably should be restored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #438
cc @skirpichev