Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #519

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Misc fixes #519

merged 2 commits into from
Oct 5, 2024

Conversation

skirpichev
Copy link
Contributor

  • more samples + test str(int)==str(mpz) in test_mpz_conversion_bulk()
  • more correct error message for MPZ_OVERFLOW error in GMP

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.62%. Comparing base (224745b) to head (71c1186).
Report is 52 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
+ Coverage   85.52%   85.62%   +0.10%     
==========================================
  Files          50       50              
  Lines       11656    11704      +48     
  Branches     2202     2213      +11     
==========================================
+ Hits         9969    10022      +53     
+ Misses       1687     1682       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@casevh casevh marked this pull request as ready for review October 4, 2024 03:51
@casevh
Copy link
Collaborator

casevh commented Oct 4, 2024

gmpy used the custom memory allocation feature of GMP to to wrap the malloc calls and raise MemoryError if they failed. It didn't catch all core dumps but this patch looks like a better option. Is there any advantage to raising MemoryError in a future release? (Just having more informative error messages on a core dump is a definite improvement.)

@casevh casevh merged commit 7460aff into aleaxit:master Oct 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants