Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude semantics on outside days when not visible #826

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jjoelson
Copy link

@jjoelson jjoelson commented Oct 9, 2023

Hi all! I have a minor change here to improve the screen reader experience.

Currently, when CalendarStyle.outsideDaysVisible is set to false the table cells representing outside days can be focused by screen readers. Nothing is read when an outside day is focused, so screen reader users are likely to be confused and may not realize they need to skip over several empty cells. It looks like this:

image

This PR excludes semantics on those empty cells when CalendarStyle.outsideDaysVisible is false.

Currently, when `CalendarStyle.outsideDaysVisible` is set to false the
table cells representing outside days can be focused by screen readers.
Nothing is read when an outside day is focused, so screen reader users
are likely to be confused and may not realize they need to skip over
several empty cells.

This commit excludes semantics on those empty cells when
`CalendarStyle.outsideDaysVisible` is false.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant