This PR fixes ADA screen reader issues for days outside the current month in the calendar. #885
+5
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| final isOutside = day.month != focusedMonth.month; | ||
|
|
||
| if (isOutside && _shouldBlockOutsideDays) { | ||
| return Container(); |
There was a problem hiding this comment.
suggestion : use SizedBox.shrink() instead of Container();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the screen reader would announce "Text" on iOS for outside days when visibility is set to false, and on Android, users were able to tap the blank cells. This PR resolves these issues by returning a
Containerwidget at the earliest possible stage. As a result, noGestureDetectoris created, and the cells are not tappable. This ensures a better user experience and ADA compliance. Thank you.