Update decorated sensor state changes to look a little flux-ier #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenia
commented
Oct 25, 2020
| const newBracket = this.calculateAQINotifyBracket(data.AQI) || this.currentAQINotifyBracket; | ||
| this.calculateAQIThresholds(data.AQI); | ||
| if(newBracket && newBracket !== this.currentAQINotifyBracket) { | ||
| this.currentAQINotifyBracket = this.calculateAQINotifyBracket(data.AQI); |
There was a problem hiding this comment.
This is the "magic" line that becomes way more explicit in the updateAQIMonitoringState method
|
Note this does not add any functionality except in more explicit logging, it's a strict refactor that keeps the tests green. |
alenia
commented
Oct 25, 2020
| return this.formatReport(data); | ||
| } | ||
|
|
||
| private updateAQIMonitoringState(AQI: number, forceReset = false) : { old: monitoringState; new: monitoringState, bracketChange: notifyBracket, changed: boolean } { |
There was a problem hiding this comment.
Old and new states are only used for logging at this point. The bracketChange and changed flags are the relevant ones. Bracket change is whether the AQI is outside of the previous AQI boundaries (and in what direction).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if I want to do this refactor or not. This makes all the state changes more explicit but also wordier. If it looks like I want to move this direction in the future I can build on it?