Merge pull request #169 from alerta/update-notification-sound

Play notification sound for new (ie. not repeat) open alerts
alerta · May 11, 2019 · 7a1d417 · 7a1d417
2 parents ff51f42 + a928d98
commit 7a1d417
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/public/audio/Bike Horn.mp3 b/public/audio/Bike Horn.mp3
diff --git a/public/audio/alert_high-intensity.ogg b/public/audio/alert_high-intensity.ogg
diff --git a/src/components/Preferences.vue b/src/components/Preferences.vue
@@ -28,7 +28,6 @@
             label="Play notification sounds"
             hide-details
             class="my-0"
-            :disabled="!$config.audio.new"
           />
         </v-radio-group>
       </v-card-actions>
@@ -173,7 +172,7 @@ export default {
     },
     isPlaySounds: {
       get() {
-        return this.$config.audio.new ? !this.$store.getters.getPreference('isMute') : false
+        return !this.$store.getters.getPreference('isMute')
       },
       set(value) {
         this.$store.dispatch('toggle', ['isMute', !value])

diff --git a/src/store/modules/preferences.store.ts b/src/store/modules/preferences.store.ts
@@ -4,7 +4,8 @@ import stateMerge from 'vue-object-merge'
 const getDefaults = () => {
   return {
     isDark: false,
-    isMute: false,
+    isMute: true,
+    audioURL: '/audio/alert_high-intensity.ogg',
     dates: {
       longDate: 'ddd D MMM, YYYY HH:mm:ss.SSS Z',
       mediumDate: 'ddd D MMM HH:mm',

diff --git a/src/views/Alerts.vue b/src/views/Alerts.vue
@@ -3,7 +3,7 @@
 
     <audio
       ref="audio"
-      :src="$config.audio.new"
+      :src="audioURL"
     />
 
     <alert-detail
@@ -117,6 +117,9 @@ export default {
     timer: null
   }),
   computed: {
+    audioURL() {
+      return this.$config.audio.new || this.$store.getters.getPreference('audioURL')
+    },
     defaultTab() {
       return utils.fromHash(this.hash).environment ? `tab-${utils.fromHash(this.hash).environment}` : 'tab-ALL'
     },