This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
GStreamerMediaPlayer: accept full GstBin descriptions in "audioSink" #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than only accept a sink element type in SampleApp config's gstreamerMediaPlayer -> audioSink setting (like "alsasink" or "pulsesink"), let the user specify the name plus any parameters and even multiple subelements to go at the end of the pipeline if needed. The following is a useful example: "audioSink":"pulsesink stream-properties=\"props,media.role=announce\"" in combination with the pulseaudio "module-role-ducking" module to enable attenuating music and other audio during Alexa announcements.
This has probably been fixed in upstream googletest but since avs-device-sdk doesn't accept contributions there's no point updating the included googletest version here.
Snowman is an opensource drop-in replacement (mostly) for Snowboy. Since they're compatible, this Keyword Detector Provider should work for Snowboy too, but the main focus is on Snowman. This is based on the Kitt.AI KWD code from older versions of avs-device-sdk.
The read from audio stream will block for as long as needed so don't set short timeout on the read call. Also read 20x bigger chunks than what porcupine asks, this may increase the detection delay but should lower the CPU usage slightly which is relatively high with porcupine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Rather than only accept a sink element type in SampleApp config's
gstreamerMediaPlayer -> audioSink setting (like "alsasink" or
"pulsesink"), let the user specify the name plus any parameters and
even multiple subelements to go at the end of the pipeline if needed.
The following is a useful example:
in combination with the pulseaudio "module-role-ducking" module to
enable attenuating music and other audio during Alexa announcements.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.