Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove empty files. #53

Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix: remove empty files. #53

merged 2 commits into from
Nov 30, 2023

Conversation

AJDERS
Copy link
Contributor

@AJDERS AJDERS commented Nov 29, 2023

By inspection, any file that is less than 200 Kb is empty, and we remove them during preprocessing.

PS: empty means now speech.

@AJDERS AJDERS linked an issue Nov 29, 2023 that may be closed by this pull request
Exclude empty soundfiles from CoRal-dataset #45
Closed
@AJDERS AJDERS self-assigned this Nov 29, 2023
@AJDERS AJDERS requested a review from saattrupdan November 29, 2023 13:41
saattrupdan
saattrupdan approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@saattrupdan saattrupdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick, LGTM 🙂

src/coral_models/prepare_raw_data.py Outdated Show resolved Hide resolved
@AJDERS AJDERS merged commit 9d47267 into main Nov 30, 2023
5 checks passed
@saattrupdan saattrupdan deleted the 45-exclude-empty-soundfiles-from-coral-dataset branch July 1, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saattrupdan saattrupdan saattrupdan approved these changes

Assignees

@AJDERS AJDERS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exclude empty soundfiles from CoRal-dataset
2 participants
@AJDERS @saattrupdan