New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8 #12

Open

kurahaupo wants to merge 1 commit into alexandrebelloni:master from kurahaupo:patch-1

kurahaupo commented Jun 30, 2024

Fix logic error


          Fix alexandrebelloni#8

247cbeb

Fix logic error

Author

kurahaupo commented Jun 30, 2024

Fixed #8

Author

kurahaupo commented Jun 30, 2024 •

edited

Loading

And... nope!

Commit 247cbeb fixes TZ=America/Iqaluit, changing

EST5EDT,M3.2.0/3,M11.1.0 (incorrect) to
EST5EDT,M3.2.0,M11.1.0 (correct).

But unfortunately it breaks TZ=Pacific/Auckland, changing

NZST-12NZDT,M9.5.0,M4.1.0/3 (correct) to
NZST-12NZDT,M9.5.0/3,M4.1.0/3 (incorrect).

I will need to investigate why, including whether the code copes with DST at the start and end of the year, rather than in the middle of the year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet