Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #114 Invalid memory reference with Filter::ia64 #117

Closed
wants to merge 1 commit into from
Closed

Fix #114 Invalid memory reference with Filter::ia64 #117

wants to merge 1 commit into from

Conversation

ChanTsune
Copy link

Hi @alexcrichton

I resolved segmentation fault reported in issue #114

As for adding -D HAVE_DECODER_IA64=1 -D HAVE_ENCODER_IA64=1 added to the issue, another problem remains, there is a lack of macros to declare the use of encoders corresponding to each Filter That's the reason.
Filters::arm requires -D HAVE_DECODER_ARM=1 -D HAVE_ENCODER_ARM=1 and Filters::arm_thumb requires -D HAVE_DECODER_ARMTHUMB=1 -D HAVE_ENCODER_ARMTHUMB=1

I think a separate PR is appropriate for this. Also HAVE_DECODER_ARMTHUMB and HAVE_ENCODER_ARMTHUMB macros are added in #116

@ChanTsune ChanTsune closed this Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant