Fix #114 Invalid memory reference with Filter::ia64
#117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @alexcrichton
I resolved segmentation fault reported in issue #114
As for adding
-D HAVE_DECODER_IA64=1 -D HAVE_ENCODER_IA64=1
added to the issue, another problem remains, there is a lack of macros to declare the use of encoders corresponding to each Filter That's the reason.Filters::arm
requires-D HAVE_DECODER_ARM=1 -D HAVE_ENCODER_ARM=1
andFilters::arm_thumb
requires-D HAVE_DECODER_ARMTHUMB=1 -D HAVE_ENCODER_ARMTHUMB=1
I think a separate PR is appropriate for this. Also
HAVE_DECODER_ARMTHUMB
andHAVE_ENCODER_ARMTHUMB
macros are added in #116