Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Russian and Portuguese #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JessRudder
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Jan 24, 2017

Coverage Status

Coverage remained the same at 96.505% when pulling a2c6c90 on JessRudder:add-language-support into c9c0ab9 on alexduryee:master.

@alexduryee
Copy link
Owner

Thanks for this! I'd like to have specs for each language supported by the library - could you add Portuguese and Russian dates to https://github.com/alexduryee/timetwister/blob/master/spec/dates_spec.rb#L620 ?

I realize now that August is a bad month to use for testing languages, since agosto appears in multiple languages. It's not necessary, but if you could change the month in the language test from August to anything else, I'd be eternally grateful.

@JessRudder
Copy link
Author

@alexduryee absolutely! It'll be a few days before I can get to that (most likely). Will it work if I provide the tests by the end of this week?

@alexduryee
Copy link
Owner

@JessRudder Sure thing! Take your time; there's no rush, and I need to diagnose an issue on my end anyway.

Thanks so much for working on this; it's tremendously appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants