Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash VMAF args for cache #165

Merged
merged 3 commits into from
Dec 30, 2023
Merged

Conversation

t-nil
Copy link
Contributor

@t-nil t-nil commented Dec 29, 2023

Changing VMAF args such as model, pool - even resolution - results in different scores. These should therefor be included in the cache key.

Things still not reflected:

  • Change in VMAF version
  • Change in default model used by VMAF (because ab-av1 doesn't set it and I see no trivial way to detect it)
  • Change in model used hardcoded by ab-av1 (if that changes, we still could invalidate all the hashes since it's very likely that none of the scores match anymore)

@alexheretic
Copy link
Owner

Good spot thanks!

@alexheretic alexheretic merged commit 2ad10ee into alexheretic:main Dec 30, 2023
3 checks passed
@t-nil t-nil deleted the hash_vmaf_for_cache branch January 1, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants