add quantum array and operations support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s - Maintains original amplitude when projecting onto basis state - Properly implements quantum projection operator
…mplitudes - Maintains original amplitude when projecting onto basis state - Properly implements quantum projection operator" This reverts commit fbdbd28.
alexjgreig
approved these changes
Feb 6, 2025
| ℝ × (Fin 2 → ℂ) := | ||
| let prob := measure_probability state basis_state | ||
| let post_state := project_state state basis_state | ||
| (prob, post_state) |
There was a problem hiding this comment.
Is the probability and post state pair returned so that it can be used for the classical and quantum state pair of the state or the program?
| Fields: | ||
| * `state` - The quantum state vector in the 2^n dimensional Hilbert space | ||
| * `is_normalized` - Proof that the state is normalized (sum of probabilities = 1) -/ | ||
| structure QArray (n : Nat) where |
There was a problem hiding this comment.
Is this going to be changed to n classical terms which are the index of each qubit? I.e when there are two classical terms, it represents a grid of qubits. Can revisit this definition after defining the other syntax and semantics first.
| else -- control = 1 | ||
| if target = (1 - j_target) then 1 else 0 | ||
| else 0 | ||
|
|
There was a problem hiding this comment.
These gates look good! Need to also implement the parametric rotation gates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quantum Types and Operations Implementation
This PR implements core quantum computing functionality for the Quave framework:
Changes